Skip to content

Refactor/deprecate functions - #722

Merged
timcadman merged 6 commits into
v7.0-devfrom
refactor/deprecate-functions
Oct 29, 2026
Merged

Refactor/deprecate functions#722
timcadman merged 6 commits into
v7.0-devfrom
refactor/deprecate-functions

Conversation

@timcadman

@timcadman timcadman commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Oct 15, 2026 •
edited
Loading

Copy link
Copy Markdown
❌ 2 of 5 checks failed
CheckResult
Devtools checks✅ passed
Code quality✅ 0 new findings (package total: 1873)
Armadillo unit tests❌ [ FAIL 0 | WARN 0 | SKIP 21 | PASS 10745 ]
Opal unit tests❌ [ FAIL 0 | WARN 0 | SKIP 21 | PASS 6219 ]
Test coverageℹ️ no coverable lines changed (project: 67.9%)

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

@codecov-commenter

codecov-commenter commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.62%. Comparing base (903426d) to head (517b4b1).

Additional details and impacted files 
@@             Coverage Diff              @@
##           v7.0-dev     #722      +/-   ##
============================================
- Coverage     68.93%   67.62%   -1.32%     
============================================
  Files           142      131      -11     
  Lines          5788     5075     -713     
============================================
- Hits           3990     3432     -558     
+ Misses         1798     1643     -155
Flag Coverage Δ
armadillo-arg 20.59% <ø> (-0.44%) ⬇️
armadillo-misc 17.85% <ø> (+2.19%) ⬆️
armadillo-perf-1 10.60% <ø> (+1.30%) ⬆️
armadillo-perf-2 19.34% <ø> (+1.51%) ⬆️
armadillo-perf-3 18.42% <ø> (+2.26%) ⬆️
armadillo-smk-1 41.49% <ø> (+6.45%) ⬆️
armadillo-smk-2 35.80% <ø> (-3.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timcadman
timcadman marked this pull request as draft October 16, 2026 08:40
@timcadman
timcadman marked this pull request as ready for review October 23, 2026 10:24
StuartWheater
StuartWheater reviewed Oct 23, 2026
View reviewed changes

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this PR need to be combined #725 to increase Opal start-up period.

@timcadman

timcadman commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

It appears this PR need to be combined #725 to increase Opal start-up period.

Ok - shall we merge 725 first then?

@StuartWheater

StuartWheater commented Oct 23, 2026

Copy link
Copy Markdown
Member

Looks like I need to make modifications to 'test-smk-ds.listServersideFunctions' to reflect method removal.

StuartWheater
StuartWheater approved these changes Oct 29, 2026
View reviewed changes

@StuartWheater StuartWheater left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given in the release 6.3.5 the methods were marked as deprecated, should we just delete the methods not leave the method with lifecycle::deprecate_stop("7.0.0", ...)

@timcadman

timcadman commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Hi Stuart, deprecate_stop() will throw an error, but the advantage is that it still keeps the function with documentation, so the user gets an error explaining the change rather than just an error that the function doesn't exist. It is the recommended flow with the lifecycle package which handles deprecation quite neatly I think

@timcadman
timcadman merged commit 0c3e66a into v7.0-dev Oct 29, 2026
30 of 42 checks passed
@timcadman
timcadman deleted the refactor/deprecate-functions branch October 29, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StuartWheater StuartWheater StuartWheater approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timcadman @codecov-commenter @StuartWheater